Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): Adjust blog authors line height to show descenders in lowercase letters (g, j, p, q, and y) #10390

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

josh-wong
Copy link
Contributor

@josh-wong josh-wong commented Aug 11, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

As mentioned in #10389, this PR fixes an issue with descenders in lowercase letters (g, j, p, q, and y) in author titles being cut off.

Important

I tried to find all places where the styles needed to be changed, but please correct me if I missed any places or if the styles need to be adjusted elsewhere or in a different way🙇🏻‍♂️

Test Plan

Confirmed my changes appear as expected locally.

Note

For problematic screenshots that show the issue, see #10389.

Blog home page

Blog home page - Lowercase descenders showing

Blog post

Blog post - Lowercase descenders showing

Blog authors page

Blog authors page - Lowercase descenders showing

Single blog author page

Single blog authors page - Lowercase descenders showing

Test links

Deploy preview: https://deploy-preview-10390--docusaurus-2.netlify.app/

Related issues/PRs

Fix #10389

@facebook-github-bot
Copy link
Contributor

Hi @josh-wong!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Aug 11, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 5fab24b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66b82d76c250bd00085b84bf
😎 Deploy Preview https://deploy-preview-10390--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 11, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 69 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 59 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 70 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 69 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 11, 2024
Adjust line height to show lowercase descenders in blog author titles.
@josh-wong josh-wong force-pushed the josh-wong/fix-blog-author-title branch from 46558f6 to 5fab24b Compare August 11, 2024 03:18
@slorber slorber changed the title Adjust line height to show descenders in lowercase letters (g, j, p, q, and y) in blog author titles fix(theme): Adjust blog authors line height to show descenders in lowercase letters (g, j, p, q, and y) Aug 12, 2024
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, missed that 😅

LGTM thanks 👍

@slorber slorber merged commit 471f0d4 into facebook:main Aug 12, 2024
36 checks passed
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowercase descenders (g, j, p, q, and y) are cut off in blog author titles
3 participants