feat(theme): show unlisted/draft banners in dev mode #10376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -638 B (-0.01%) Total Size: 11.5 MB
ℹ️ View Unchanged
|
slorber
changed the title
|
LGTM thanks Did some refactoring to cleanup but this works well |
slorber
added
the
Argos
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
FYI this broke our builds since we were using overrides for |
|
@B4nan it's not marked as a safe component to swizzle so we keep the right to do refactors like this one in minor versions. I'll see how we could make it easier for those like you who swizzle unsafe components. Maybe listing changes in our release notes would be helpful? |
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
Closed
This was referenced Oct 4, 2024
This was referenced Oct 19, 2024
Open
Open
ptgott
added a commit
to gravitational/docs-website
that referenced
this pull request
Oct 24, 2024
The module declaration was changed in facebook/docusaurus#10376
ptgott
added a commit
to gravitational/docs-website
that referenced
this pull request
Oct 24, 2024
- Upgrade Docusaurus packages to `^3.5.0` - Fix `@theme/Unlisted` import, since the module declaration was changed in facebook/docusaurus#10376. - Update imports to reflect the movement of some exports from `@docusaurus/theme-common/internal` into `@docusaurus/plugin-content-docs/client`. See facebook/docusaurus#10316.
ptgott
added a commit
to gravitational/docs-website
that referenced
this pull request
Oct 24, 2024
- Upgrade Docusaurus packages to `^3.5.0` - Fix `@theme/Unlisted` import, since the module declaration was changed in facebook/docusaurus#10376. - Update imports to reflect the movement of some exports from `@docusaurus/theme-common/internal` into `@docusaurus/plugin-content-docs/client`. See facebook/docusaurus#10316. Also updates config.json to correct branch names.
mmcallister
pushed a commit
to gravitational/docs-website
that referenced
this pull request
Oct 24, 2024
- Upgrade Docusaurus packages to `^3.5.0` - Fix `@theme/Unlisted` import, since the module declaration was changed in facebook/docusaurus#10376. - Update imports to reflect the movement of some exports from `@docusaurus/theme-common/internal` into `@docusaurus/plugin-content-docs/client`. See facebook/docusaurus#10316. Also updates config.json to correct branch names.
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #8285
Test Plan
ci & unit test & argos
Test links
Deploy preview: https://deploy-preview-10376--docusaurus-2.netlify.app/