Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use primary colour for highlighting items in table of content #1608

Closed
amimas opened this issue Jun 14, 2019 · 0 comments · Fixed by #1628
Closed

Use primary colour for highlighting items in table of content #1608

amimas opened this issue Jun 14, 2019 · 0 comments · Fixed by #1628

Comments

@amimas
Copy link

amimas commented Jun 14, 2019

💥 Proposal

We now have the feature that highlights items in table of content as the user scrolls up or down. This is a great feature and really helpful for users on long page with lots of contents.

Currently the list items are in table of content is being highlighted by using simply setting font-weight: 600 in css.

I think in addition to that, it'd be very useful if the colour can also be set to the primaryColor used in site's configuration. This will make the item in table of content stand out more and also make it consistent with sidebar navigation as well as other links on the page.

Have you read the Contributing Guidelines on issues?

Yes
parkas2018 added a commit to parkas2018/docusaurus that referenced this issue Jun 26, 2019
@parkas2018
Set colour in highlighted items in table of content
d2bf7cf 
Currently the items in table of contents are highlighted as bold based on items being
viewed on the screen or as the user scrolls up/down on a page. Added the `primaryColor`
of the site's configuration to make the current section being viewed standout more
in the table of content.

closes facebook#1608
@parkas2018 parkas2018 mentioned this issue Jun 26, 2019
Merged
yangshun pushed a commit that referenced this issue Jul 3, 2019
@parkas2018 @yangshun
feat: use primary color for highlighted items in table of contents (#…
7252197 
…1628)

Currently the items in table of contents are highlighted as bold based on items being
viewed on the screen or as the user scrolls up/down on a page. Added the `primaryColor`
of the site's configuration to make the current section being viewed standout more
in the table of content.

closes #1608
jamesgeorge007 pushed a commit to jamesgeorge007/Docusaurus that referenced this issue Jul 3, 2019
@parkas2018 @jamesgeorge007
feat: use primary color for highlighted items in table of contents (f…
aa8eda3 
…acebook#1628)

Currently the items in table of contents are highlighted as bold based on items being
viewed on the screen or as the user scrolls up/down on a page. Added the `primaryColor`
of the site's configuration to make the current section being viewed standout more
in the table of content.

closes facebook#1608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use primary color for highlighted items in table of contents parkas2018/docusaurus
1 participant
@amimas