Last Updated Time Misleading #1015
Comments
|
@yangshun - do you agree that the times are misleading? I am going to assign this to @fiennyangeln as part of her work on #980. She can fix this and use that same fix to put the last contributor of each document. |
JoelMarcey
added
mentorship
status: claimed
|
Yes, I agree they are misleading, but they are not technically wrong, because moving a file is indeed updating it strictly speaking. I'm not sure how else we can do better. Perhaps we can find the latest commit where it's not a movement but a modification. |
Exactly. I chatted with @fiennyangeln this morning and that is exactly what she was going to look at doing. I think that would be more useful information to someone reading the docs. |
|
@yangshun I feel like currently even if it's not moved, it will show the time when we start a new version, not when the content last changed before we create the version |
or otherwise when it is first created Fix facebook#1015
or otherwise when it is first created Fix facebook#1015
* Fix last updated time misleading, only show when file content change or otherwise when it is first created Fix #1015 * Fix prettier * - Simplify regex - Uses shelljs instead of cross-spawn - Make logic clearer * Add test when repositories is moved * Use shell.exec mock I initially try to mock the whole shelljs. But it returns error shell.exec is not a function when i try to provide the mockResolvedValue I think it is because of the inner code of shelljs who run a forEach to require each of its method which make it a promise. I tried moving the jest.mock inside beforeAll and also adding babel-dynamic-import but it did not solve the problem. In the end, I decided to just mock shelljs.exec since it is the only function used anyway
🐛 Bug Report
The last updated time is misleading and possibly wrong. We don't want to take into account versioning in last updated -- only content changes. Also, the folder move to
v1andv2might have made things out of whack a bit.Have you read the Contributing Guidelines on issues?
Yes
To Reproduce
Expected behavior
The correct last updated time based on content changes
Actual Behavior
Every doc has the same last updated time.
Reproducible Demo
https://docusaurus.io
The text was updated successfully, but these errors were encountered: