Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose error overlay when linting errors have been corrected #856

Merged
merged 3 commits into from
Oct 11, 2016

Conversation

jarlef
Copy link
Contributor

@jarlef jarlef commented Oct 5, 2016

Remove error overlay when linting errors have been corrected and the next webpack linting is successful / contains only warnings.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -123,6 +123,18 @@ function showErrorOverlay(message) {
});
}

function destoryOverlay() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, but you probably meant "destroy" rather than "destory", right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. pardon my spelling error ;-)

@gaearon gaearon added this to the 0.7.0 milestone Oct 11, 2016
@gaearon gaearon merged commit 4e5a561 into facebook:master Oct 11, 2016
@gaearon
Copy link
Contributor

gaearon commented Oct 11, 2016

Thanks!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
…ok#856)

* Dispose error overlay when linting errors have been corrected

* Fixed spelling error

* Minor style tweaks
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants