added check for typescript template and unsupported node version

[awaseem]

This PR related to #7715

Problem

When using the --typescript option with create-react-app with an unsupported version node.js ie. from the issue 8.9.4. It creates a React project, but completely ignores the TypeScript template.

Whats happening is that before this fix, if you're using an unsupported version of Node.js, createReactApp.js falls back to using version 0.9.5. Within 0.9.5, the init script (or scripts/init.js) there is no code paths that support the TypeScript option. This is why you can still get a react app project, but without TypeScript being configured.

Solution

Within createReactApp.js I just added a check and error message that tells the user they must upgrade to a supported version to continue

Testing

I tested the command using nvm, 8.10 fully created a TypeScript project but anything below exits with the following message:

You are using Node v8.9.4 with the TypeScript template. Since the old unsuporoted version of tools do not supported TypeScript, you will have to upgrade.

Please update to Node 8.10 or higher for a better, fully supported experience.

Please let me know if you have any questions!

[facebook-github-bot]

Hi awaseem! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[iansu]

We don't have any tests for this functionality. Have you tested it locally and verified things work as expected?

[awaseem]

We don't have any tests for this functionality. Have you tested it locally and verified things work as expected?

I actually just tested it with my local machine. You can see it working below:

If you want I can totally write a e2e test, might just take longer

[iansu]

I'm not going to stop you from writing a test for it. 😀

But I'm okay to merge this as is. If you do want to write a test as a follow up that would be great too! Let me know what you want to do.

[awaseem]

If you're comfortable with merging this, I can create another issue to track the e2e tests and create a PR based on that.

[iansu]

Thanks!