Fix linting error when using rest props

[alexandrtovmach]

Fixes #7753 that's affected by breaking change in webpack-contrib/eslint-loader#294

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[alexandrtovmach]

@ianschmitz Seems like build fails... again. Could you restart?

[ianschmitz]

@ianschmitz Seems like build fails... again. Could you restart?

I triggered a new build, but it seems to still be failing for the same reason.

[alexandrtovmach]

This is Azure pipeline issues I think. You can try to run one-by-one to reduce service load

[alexandrtovmach]

This fails not related to my changes it's 100% sure

[ianschmitz]

The KitchenSink/KitchenSinkEject suites on Linux have the same errors when running locally. It's not a pipelines issue. You can repro using yarn e2e:docker --test-suite kitchensink.

I know people want a fix, but i don't feel comfortable merging this as-is because it looks like there may be other rest/spread issues when linting still.

Would you be able to debug this @alexandrtovmach?

[alexandrtovmach]

@ianschmitz I can take a look just tomorrow morning (almost midnight for me now) so if someone else can investigate in it quicker - go ahead)

If not, I'll fix it in 10 hours

[ianschmitz]

@alexandrtovmach it seems to have sorted itself. Tests are now passing on my local machine and in CI. Thanks!

[chrisreedtech]

@ianschmitz
I'm still having this issue. Is there a certain version of a package that I might have listed in my package.json that could be causing this?

This is my package.json.
`

{
"name": "ui",
"version": "0.0.1",
"private": true,
"proxy": "http://redacted:8000",
"dependencies": {
"react": "16.9.0",
"react-dom": "16.9.0",
"react-scripts": "3.1.2",
"@material-ui/core": "latest",
"axios": "0.19.0",
"react-router-dom": "5.1.0"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject"
}
}

`

[kentcdodds]

@chrisreedio, I believe it's because this hasn't been released yet. Hopefully it will be soon. You can check the npm page to know when the last release was (which was 11 days ago at the time of this writing).

Thanks to @alexandrtovmach for the PR and @ianschmitz for merging 👏

[alexandrtovmach]

@ianschmitz Yeah, as I said the problem is not related to my changes =) So it's merged, but when it'll be live? I can't find any estimates for 3.1.3

[chrisreedtech]

Is there a work around? I tried forcing [email protected] and I still have the issue. Somehow this issue broke my builds. Which I found odd given I was specifying exact versions.

Appreciate your time!

[alexandrtovmach]

@chrisreedio My fix is not available now, so you need to use one of temporary solutions:
#7753 (comment)
#7753 (comment)

[chrisreedtech]

@alexandrtovmach Thank you!