-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add babel runtime version to transform-runtime plugin to reduce bundle size #7726
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I can confirm there are several issues with the version of helpers being used. Our bundle size is very bloated thanks to All research points to this PR being the fix. |
@topaxi have you verified that this change shrinks your bundle size? |
Yes, this reduces the filesize of each of our chunks by about 200 bytes after gzip. |
Thanks @topaxi! |
@topaxi @ianschmitz Is there a reason we're not doing the same when compiling dependencies here? Just curious. Edit: Nevermind. Looks like @babel/runtime is excluded from dependencies. |
(Reopening due to force-push #7725)
By default, babel assumes babel/helpers version 7.0.0-beta.0, this PR explicitly resolves the helpers to match the provide functions.
See: babel/babel#10261
Looking at the code in babel-plugin-transform-runtime/src/index.js it does not seem to be enough to provide an absolute path to the runtime.