-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warns when the user is using special webpack syntax #736
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
014840b
Add plugin that warns about webpack disable loader syntax
rogeriochaves cfdb894
Add WarnAboutDisablingPlugin to README
rogeriochaves a8cd88f
Change matcher to the right one and fix typos
rogeriochaves 0f27bdc
Add WarnAboutLoaderDisablingPlugin to webpack dev config
rogeriochaves 98b861b
Change warning to a hard error
rogeriochaves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
packages/react-dev-utils/BlockUnsupportedWebpackLoaderSyntax.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* Copyright (c) 2015-present, Facebook, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
*/ | ||
|
||
// This Webpack plugin forbids usage of special webpack syntax | ||
// to disable loaders (https://webpack.github.io/docs/loaders.html#loader-order) | ||
// This makes it very coupled to webpack and might break in the future. | ||
// See https://github.com/facebookincubator/create-react-app/issues/733. | ||
|
||
'use strict'; | ||
|
||
class BlockUnsupportedWebpackLoaderSyntax { | ||
apply(compiler) { | ||
compiler.plugin('normal-module-factory', (normalModuleFactory) => { | ||
normalModuleFactory.plugin('before-resolve', (data, callback) => { | ||
let error = null; | ||
if (data.request.match(/^-?!!?/)) { | ||
error = `You are requesting '${data.request}'. Special Webpack Loaders syntax is not officially supported and makes you code very coupled to Webpack, which might break in the future, we recommend that you remove it. See https://github.com/facebookincubator/create-react-app/issues/733`; | ||
} | ||
callback(error, data); | ||
}); | ||
}); | ||
} | ||
} | ||
|
||
module.exports = BlockUnsupportedWebpackLoaderSyntax; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be best to use the exact same regexps as webpack uses for this (which I believe can be found here https://github.com/webpack/webpack/blob/master/lib/NormalModuleFactory.js#L86)