-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eslintrc overrides key should be an array, not object #7219
fix: eslintrc overrides key should be an array, not object #7219
Conversation
Array format for `overrides` key in eslint config file is now enforced in ESLint v6. Anyone who uses `eslint-config-react-app` and ESLint v6 gets a type mismatch error. This commit fixes the error by converting the object into a one-element array containing this object. Only 2 characters are added: `[` and `]`. The large diff is due to formatting.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks @ivan-aksamentov! |
…book#7219) Array format for `overrides` key in eslint config file is now enforced in ESLint v6. Anyone who uses `eslint-config-react-app` and ESLint v6 gets a type mismatch error. This commit fixes the error by converting the object into a one-element array containing this object. Only 2 characters are added: `[` and `]`. The large diff is due to formatting.
…book#7219) Array format for `overrides` key in eslint config file is now enforced in ESLint v6. Anyone who uses `eslint-config-react-app` and ESLint v6 gets a type mismatch error. This commit fixes the error by converting the object into a one-element array containing this object. Only 2 characters are added: `[` and `]`. The large diff is due to formatting.
Attempts to fix #7218
Array format for
overrides
key in eslint config file is now enforced to be an array in ESLint v6. Anyone who useseslint-config-react-app
and ESLint v6 gets a type mismatch error:This commit fixes the error by converting the object into a one-element array containing that object. Only 3 characters are added:
[
,]
and,
. The large diff is due to formatting.