Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change NODE_ENV and PUBLIC_URL into readonly #6750

Merged
merged 1 commit into from
Apr 7, 2019
Merged

change NODE_ENV and PUBLIC_URL into readonly #6750

merged 1 commit into from
Apr 7, 2019

Conversation

xiaoxiangmoe
Copy link
Contributor

after change it

process.env.NODE_ENV = 'development'

will throw

Cannot assign to 'NODE_ENV' because it is a read-only property.ts(2540)

@Timer Timer added this to the 3.0 milestone Apr 4, 2019
mrmckeb
mrmckeb approved these changes Apr 7, 2019
View reviewed changes
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, @xiaoxiangmoe. Let's get this one in!

@mrmckeb
Copy link
Contributor

mrmckeb commented Apr 7, 2019

@xiaoxiangmoe - can you please rebase from master and see if that fixes your tests, I'm assuming it will. I know the tests failures are unrelated, but I think we should make sure they're passing regardless.

CC @iansu @ianschmitz

@mrmckeb mrmckeb merged commit ebabd18 into facebook:master Apr 7, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Apr 7, 2019

Thanks again, @xiaoxiangmoe

@lock lock bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@mrmckeb mrmckeb mrmckeb approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@iansu iansu Awaiting requested review from iansu

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: breaking change
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@xiaoxiangmoe @mrmckeb @ianschmitz @Timer @facebook-github-bot