Readme: add Travis-CI badge so people can easily see there is tests #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| @@ -1,5 +1,7 @@ | |||
| # Create React App | |||
|
|
|||
| [](https://travis-ci.org/facebookincubator/create-react-app) | |||
There was a problem hiding this comment.
I'd prefer to put it in the header, like in https://github.com/facebook/react.
There was a problem hiding this comment.
I am not a fan of this approach as it make it harder to maintain the badges, especially when you have more than one :)
|
I made the adjustment, feel free to squash & merge. |
|
Looks good to me. Thanks @MoOx! |
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
…acebook#646) * Readme: add Travis-CI badge so people can easily see there is tests Following https://twitter.com/MoOx/status/776008513252392960 * Readme: add Travis-CI badge so people can easily see there is tests, round 2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://twitter.com/MoOx/status/776008513252392960