Fix mjs handling for graphql
#5257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansu
reviewed
Oct 2, 2018
| // https://github.com/facebook/create-react-app/issues/5234 | ||
| describe('issue #5234 (mjs files are imported as static files)', () => { | ||
| it('correctly bundles files in development', async () => { | ||
| const browser = await puppeteer.launch({ headless: true }); |
|
I really don't like this PR. I'd like to somehow use the Then again, this will probably be standard behavior in a few more months when Node stabilizes its direction and Jest adds formal support. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5234.
Closes #5235.
This pull request allows packages to import from dependencies who export a
mjsfile (instead of us giving a URL).It also ensures that a user who uses
mjsin their application gets a file.I'm really getting tired of all of these
mjshacks, because now we "sort of" supportmjs. e.g.:If a user defines their
modulefield inpackage.jsonasindex.mjsand then explicitly import files with.mjsinstead of being extensionless, we'll keep loading them.I wonder if we can somehow tell webpack to not use
moduleif the field ismjs? That would prevent this hack.