Use jsdom environment for tests by default #3962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
commented
Feb 2, 2018
| @@ -33,7 +33,7 @@ module.exports = (resolve, rootDir, srcRoots) => { | |||
| ], | |||
| // where to search for files/tests | |||
| roots: srcRoots.map(toRelRootDir), | |||
| testEnvironment: 'node', | |||
| testEnvironment: 'jsdom', | |||
There was a problem hiding this comment.
This can actually be omitted, because that's the Jest's default, but decided to left as is for now.
|
Let's hold off merging until 2.0 or people will be confused by contradictory docs. |
|
Cool, changes are rather minimal. Ping me when you need a rebase or something. And have a great weekend! :) |
|
You too. Thanks! |
|
Oops, I didn't see this PR and just made the same change! Our patches our slightly different though, see #5074. |
|
Haha, no worries! I thought it was merged already XD |
|
Awesome! 🎉 Sorry again. 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like
--env=jsdombeing present in test command, so I'm happy to remove it as a part of #3887Resolves #3887