Don't use app node_modules folder as a resolve fallback #3884
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior was originally introduced in #1359 as we thought it would fix the
npm link
development workflow issues.However, we have since found several problems with it:
There are also gotchas like webpack/webpack#985 (comment), and I feel like it’s only going to get worse once we start supporting monorepos (#3741).
I propose that we completely disable this behavior for now. People who really need it can use an escape hatch: add
NODE_PATH=node_modules
to their.env
file. This restores the 1.x behavior (and conveniently works in Jest too).Our recommendation in any case will be to use monorepos instead (#3741) and stop relying on
npm link
.