Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a localhost-only log message pointing folks to the PWA docs #3455

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

jeffposnick
Copy link
Contributor

R: @gaearon @Timer

This adds in an additional log message pointing folks to https://goo.gl/SC7cgQ (I could use a different URL shortener or just include the full URL if you'd prefer.)

It's displayed every time registerServiceWorker() is called and there's a service worker active on localhost. Displaying it on each load should give it higher visibility vs. the other logging messages which are only displayed when content is initially cached or content is updated.

I hope it will help with the type of questions that come up at, e.g., #2398 (comment)

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Timer
Copy link
Contributor

Timer commented Nov 15, 2017

Excellent @jeffposnick! Thank you. Seems the CLA bot isn't happy though. 🤔

@Timer Timer added this to the 1.0.17 milestone Nov 15, 2017
@jeffposnick
Copy link
Contributor Author

(We've dealt with the CLA out-of-band for previous contributions to this repo, and that should still be in effect.)

@Timer
Copy link
Contributor

Timer commented Nov 15, 2017

No problem, this change is small anyway. 😄

@Timer Timer merged commit daf8df1 into facebook:master Nov 15, 2017
placenamehere pushed a commit to automatastudios/create-react-app that referenced this pull request Nov 30, 2017
@gaearon gaearon mentioned this pull request Jan 15, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

This is out in [email protected]! Please let us know if something doesn’t quite work.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants