Add a localhost-only log message pointing folks to the PWA docs #3455
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Excellent @jeffposnick! Thank you. Seems the CLA bot isn't happy though. 🤔 |
|
(We've dealt with the CLA out-of-band for previous contributions to this repo, and that should still be in effect.) |
|
No problem, this change is small anyway. 😄 |
|
This is out in |
R: @gaearon @Timer
This adds in an additional log message pointing folks to https://goo.gl/SC7cgQ (I could use a different URL shortener or just include the full URL if you'd prefer.)
It's displayed every time
registerServiceWorker()is called and there's a service worker active onlocalhost. Displaying it on each load should give it higher visibility vs. the other logging messages which are only displayed when content is initially cached or content is updated.I hope it will help with the type of questions that come up at, e.g., #2398 (comment)