Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add envinfo package, —info flag #3408

Merged
merged 2 commits into from
Jan 9, 2018

Conversation

tabrindle
Copy link
Contributor

I realize the file says not to modify the createReactApp.js, but a better way to do this did not occur to me. If there is a better way, I am certainly open to it.

To help the issue process and better narrow down environment and version issues, I have added create-react-app --info which should print the following:

Environment:
  OS: macOS High Sierra 10.13
  Node: 8.6.0
  Yarn: 1.2.1
  npm: 5.5.1
  Watchman: 4.9.0

Packages: (wanted => installed)
  react: ^16.0.0 => 16.0.0
  react-dom: ^16.0.0 => 16.0.0
  react-scripts: 1.0.17 => 1.0.17

@gaearon
Copy link
Contributor

gaearon commented Nov 6, 2017

Let's also check for duplicate react / react-dom in the tree?

@tabrindle
Copy link
Contributor Author

That's a great idea. Will add.

@tabrindle
Copy link
Contributor Author

With the new option--duplicates on envinfo, duplicates will now also show in parentheses.

Environment:
  OS: macOS High Sierra 10.13
  Node: 8.6.0
  Yarn: 1.2.1
  npm: 5.5.1
  Watchman: 4.9.0

Packages: (wanted => installed)
  react: 16.0.0 => 16.0.0 (15.6.2)

You can actually test this in an existing CRA with npx [email protected] --packages "react,react-dom,react-scripts" --noNativeIDE --duplicates

@bondz
Copy link
Contributor

bondz commented Nov 12, 2017

Still doesn't have a react-scripts-dangerous version to test out. cc @Timer

The test failure isn't related to this PR.

@tabrindle
Copy link
Contributor Author

Is there anything I can do to trigger the test build for react-scripts-dangerous?

@bondz
Copy link
Contributor

bondz commented Dec 13, 2017

Ping @Timer

@Timer
Copy link
Contributor

Timer commented Dec 13, 2017

I shut off the react-scripts-dangerous bot as I started to get quite expensive.

image

Cost $6 for two months, then randomly went wild -- no clue what happened here. 😅

@bondz
Copy link
Contributor

bondz commented Dec 13, 2017

Whaat! That's a bummer @Timer. Was really helpful but doesn't make sense if it costs you that much. Thanks for building it. Maybe we can find someone willing to host it later.

@Timer
Copy link
Contributor

Timer commented Dec 13, 2017

I think there was just some bug that caused the lambdas to run rampant; eventually when I have some free time I'll adjust it to prevent this from happening again.

@bondz bondz mentioned this pull request Jan 3, 2018
@gaearon gaearon merged commit b507a9a into facebook:master Jan 9, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2018

Looks like a good start. Let's get this in and iterate.

@gaearon gaearon added this to the 1.0.18 milestone Jan 9, 2018
@gaearon gaearon mentioned this pull request Jan 15, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

This is out.
Can you send a PR to issue template to ask for this info please?

@bondz
Copy link
Contributor

bondz commented Jan 15, 2018

See #3797

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants