Add flow typechecking as a webpack plugin #1854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will not process them for now...
This result will not be used for serving the pages but will be used for tracking lint/type errors in those files
This will only run if a @flow annotation is seen: - At the first @flow file found: - Write a .flowconfig if none exists - [Not done yet] Run flow-typed install - [Not done yet] Start a flow instance - When a file with an @flow comment changes during a compilation: - [Not done yet] Run a flow check - If there are some errors in flow: - If CI: output as an error - If not CI: output as a warning
We don't need complex logic with process.env on the plugin side, we let the build script figure this out!
If a mismatch occurs, the DX will be bad, we should tell it to the user
It's now useless
# Conflicts: # packages/react-dev-utils/package.json # packages/react-scripts/config/webpack.config.dev.js
# Conflicts: # packages/react-scripts/config/webpack.config.dev.js # packages/react-scripts/config/webpack.config.prod.js
14 tasks
|
Sure, thanks. Whatever keeps the ball rolling :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR by @rricard but without adding flow-typed to the gitignore.