Add first CONTRIBUTING.md #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
||
| ## Core ideas | ||
|
|
||
| We do not want any flags or configuration, these will only lead us down a path of becoming the next webpack. We want to find good defaults and actively find ways to improve the developer experience. |
There was a problem hiding this comment.
I think the first sentence is a little too harsh to webpack for official doc (I know I said it in comments but still). What we’re trying to say is that adding configuration and flags defeats the purpose of this tool.
|
Updated! |
|
This is a fine start, thanks. We can make it better over time. Next step would be to move instructions from README into it, and to link from README to that doc. |
|
👉 #160 |
kalekseev
pushed a commit
to kalekseev/create-react-app
that referenced
this pull request
Sep 11, 2017
…_TEMPLATE.md fixed merge typo in ISSUE_TEMPLATE.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a first CONTRIBUTING.md.
Still missing is something about the release process, and also I think we should add something about how to submit bug reports, similar to the html5boilerplate CONTRIBUTING.md!
Ref #92