Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds simple HMR for React #133

Closed
wants to merge 1 commit into from
Closed

Adds simple HMR for React #133

wants to merge 1 commit into from

Conversation

sheepsteak
Copy link
Contributor

This doesn't require any extra plugins or setup and will work for function components too unlike #110 (I think react-hot-loader@3 fixes this?). Also, this is easy to remove with a codemod as desired in #111 as the whole if statement can just be removed.

@ghost ghost added the CLA Signed label Jul 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2016

Hi, thanks for PR.

We won't do this for now because now we'd have to explain what module.hot is, why you have to use require or .default, etc.

This will get better with Webpack 2. Still we prefer that for now, this doesn't come by default because it will confuse people just learning React. This could, however, be a handy tip to blog about.

@gaearon gaearon closed this Jul 23, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants