Avoid no-floating-promises ESLint problem #11794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, also happy to add a proper |
iansu
suggested changes
Jan 12, 2022
| getLCP(onPerfEntry); | ||
| getTTFB(onPerfEntry); | ||
| }) | ||
| .catch(() => {}); |
There was a problem hiding this comment.
This seems like a good fix for this issue but if there is a real error with the import it will be swallowed. Can you catch and log any error that might happen instead?
There was a problem hiding this comment.
Yep, for sure, I'll just use console.error then
|
@iansu any further feedback on this PR? Do you think we could get it merged / released? |
|
An alternative to this PR is the following PR, which removes |
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
First of all, thanks for all the amazing work that goes into maintaining
create-react-appandreact-scripts. We've seen a lot of success with teaching it at @upleveled.Recently came across
@typescript-eslint/no-floating-promises(from tweets like https://mobile.twitter.com/flybayer/status/1469098848958222337) and it has problems with the code inreportWebVitals.jsThis avoids the issue without changing the functionality