Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate root level template.json keys #11188

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Deprecate root level template.json keys #11188

merged 1 commit into from
Jul 14, 2021

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Jul 7, 2021

This PR deprecates root-level dependencies and scripts keys in template.json (see code). They now need to be nested under a package key.

We've had a warning in place for this for a long time, and we made this change very early on so this shouldn't have any large impact.

@mrmckeb mrmckeb added this to the 4.1 milestone Jul 7, 2021
@mrmckeb mrmckeb requested a review from iansu July 7, 2021 17:36
@mrmckeb mrmckeb self-assigned this Jul 7, 2021
@iansu iansu merged commit 9358f50 into main Jul 14, 2021
@iansu iansu deleted the feature-v5-template-json-change branch July 14, 2021 17:18
@Methuselah96 Methuselah96 mentioned this pull request Jul 28, 2021
Merged
sumanthratna pushed a commit to sumanthratna/create-react-app that referenced this pull request Aug 4, 2021
@mrmckeb @sumanthratna
Deprecate root level template.json keys (facebook#11188)
ac6325c
EhsanFortuna pushed a commit to EhsanFortuna/create-react-app that referenced this pull request Aug 23, 2021
@mrmckeb
Deprecate root level template.json keys (facebook#11188)
31978f8
@meckila meckila mentioned this pull request Feb 11, 2022
Closed
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@mrmckeb @abhiisheek
Deprecate root level template.json keys (facebook#11188)
a7dfb9b
@Omrisnyk Omrisnyk mentioned this pull request Nov 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 12, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 22, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 14, 2024
Open
@rawanst rawanst mentioned this pull request May 17, 2024
Open
@ntnguyencse ntnguyencse mentioned this pull request May 18, 2024
Open
@rawanst rawanst mentioned this pull request May 18, 2024
Open
@JMARRUJO91 JMARRUJO91 mentioned this pull request May 20, 2024
Merged
This was referenced May 21, 2024
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request May 23, 2024
Open
This was referenced May 23, 2024
Open
Open
@rawanst rawanst mentioned this pull request Sep 26, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 26, 2024
Open
@rawanst rawanst mentioned this pull request Sep 27, 2024
Open
@Hiranyape Hiranyape mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 27, 2024
Open
Open
@rawanst rawanst mentioned this pull request Sep 28, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 1, 2024
Merged
@rawanst rawanst mentioned this pull request Oct 1, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 1, 2024
Open
@rawanst rawanst mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 3, 2024
Open
@rawanst rawanst mentioned this pull request Oct 3, 2024
Open
@SanielDev SanielDev mentioned this pull request Oct 3, 2024
Open
@rawanst rawanst mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@SanielDev SanielDev mentioned this pull request Oct 6, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 15, 2024
Open
@Laurry-gee Laurry-gee mentioned this pull request Oct 21, 2024
Open
@nerds-github nerds-github mentioned this pull request Oct 23, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 28, 2024
Open
@rawanst rawanst mentioned this pull request Oct 29, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 31, 2024
Open
@barunslick barunslick mentioned this pull request Oct 31, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Nov 5, 2024
Open
@rawanst rawanst mentioned this pull request Nov 5, 2024
Open
@GregBrimble GregBrimble mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansu iansu iansu approved these changes

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@petetnt petetnt Awaiting requested review from petetnt

Assignees

@mrmckeb mrmckeb

Labels
CLA Signed tag: breaking change tag: internal
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mrmckeb @iansu @facebook-github-bot