Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Don’t use “JSX uses React” with new runtime #9782

Closed
gaearon opened this issue Oct 11, 2020 · 2 comments · Fixed by #9788
Closed

[v4] Don’t use “JSX uses React” with new runtime #9782

gaearon opened this issue Oct 11, 2020 · 2 comments · Fixed by #9788

Comments

@gaearon
Copy link
Contributor

gaearon commented Oct 11, 2020

When using the new JSX transform, we should disable the “jsx uses react” ESLint rule. Otherwise you can’t remove the React import — which is one of the points of the new transform.

We should verify that our default template works without the React import in App.js, including the test environment.

@gaearon gaearon changed the title [v4] Don’t use “JSX uses React” with new rhbtime [v4] Don’t use “JSX uses React” with new runtime Oct 11, 2020
@mrmckeb mrmckeb self-assigned this Oct 12, 2020
@mrmckeb
Copy link
Contributor

mrmckeb commented Oct 12, 2020

I'll take a look at this alongside the other work - I think it will also apply to react/react-in-jsx-scope.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 12, 2020

Ahh yup that's actually the one that's the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants