Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Change JSX runtime detection mechanism to presence of /jsx-runtime.js #9772

Closed
gaearon opened this issue Oct 9, 2020 · 2 comments · Fixed by #9788
Closed

[v4] Change JSX runtime detection mechanism to presence of /jsx-runtime.js #9772

gaearon opened this issue Oct 9, 2020 · 2 comments · Fixed by #9788
Labels
issue: bug report needs triage
Milestone
4.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Oct 9, 2020

#9645 detects 17+ which is not ideal because we're planning to release 16.x, 15.x, and 0.14.x releases with the new JSX runtime included. Ideally we should instead look at whether react/jsx-runtime.js exists.
@gaearon gaearon mentioned this issue Oct 9, 2020
Merged
@mrmckeb mrmckeb added this to the 4.0 milestone Oct 11, 2020
@mrmckeb
Copy link
Contributor

mrmckeb commented Oct 11, 2020

We need to do some work on this anyway (for Jest support), so we can make all of these changes at once.

@iansu I can pick this up tomorrow if that's OK with you?

@gaearon
Copy link
Contributor Author

gaearon commented Oct 11, 2020

Related #9782

@mrmckeb mrmckeb mentioned this issue Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug report needs triage
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

fix: resolve new JSX transform issues facebook/create-react-app
2 participants
@gaearon @mrmckeb