Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compression in webpack-dev-server #966

Closed
frontsideair opened this issue Oct 26, 2016 · 6 comments
Closed

Compression in webpack-dev-server #966

frontsideair opened this issue Oct 26, 2016 · 6 comments
Milestone
0.8.0

Comments

@frontsideair
Copy link
Contributor

Is there a reason that compress key is not set in WebpackDevServer config? I tried it on my machine and it made reloads faster and bandwidth usage smaller without any apparent problems.

I can send a PR if that's okay.
@gaearon
Copy link
Contributor

gaearon commented Oct 26, 2016

PR sounds good.

frontsideair pushed a commit to frontsideair/create-react-app that referenced this issue Oct 26, 2016
Enable compression on webpack-dev-server (facebook#966)
5ff2b22
gaearon pushed a commit that referenced this issue Oct 28, 2016
@frontsideair @gaearon
Enable compression on webpack-dev-server (#966) (#968)
ca443ab
kitze added a commit to kitze/custom-react-scripts that referenced this issue Nov 4, 2016
@kitze
Merge branch 'master' of https://github.com/facebookincubator/create-…
d444609 
…react-app

# By Ville Immonen (11) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app: (39 commits)
  Remove redundant `function` from export statement (facebook#996)
  Add Gatsby to alternatives (facebook#995)
  Allow webpack 2 as peerDependency in react-dev-utils (facebook#963)
  Remove custom babel-loader cache dir config (facebook#983)
  Check for presence of folders before continuing eject. Closes facebook#939. (facebook#951)
  Fixes facebook#952 (facebook#953)
  Always build before deploying to gh-pages (facebook#959)
  Add collectCoverageFrom option to collect coverage on files without any tests. (facebook#961)
  Catch and noop call to open web browser. (facebook#964)
  Gently nudge users towards https by default (facebook#974)
  Enable compression on webpack-dev-server (facebook#966) (facebook#968)
  Add next.js to Alternatives
  Point people to npm Windows instructions
  Encourage people to try recent npm
  Fix an attribution link in 0.7.0 changelog
  Update CLI version in changelog
  Publish
  Update eslint-config-react-app version in the guide
  Update changelog for 0.7.0
  Revert "Temporarily remove 0.7.0 changelog as it's not out yet"
  ...

Conflicts:
	packages/babel-preset-react-app/package.json
	packages/create-react-app/package.json
	packages/eslint-config-react-app/package.json
	packages/react-dev-utils/package.json
	packages/react-scripts/config/webpack.config.dev.js
	packages/react-scripts/config/webpack.config.prod.js
	packages/react-scripts/package.json
eXtreme added a commit to eXtreme/create-react-app that referenced this issue Nov 18, 2016
@eXtreme
Merge pull request #2
7747830 
* pull2:
  Support Yarn (facebook#898)
  Fix chrome tab reuse (facebook#1035)
  Remove unnecessary transform plugins for object spread to work (facebook#1052)
  Clears the usage of react-jsx-source & react-jsx-self (facebook#992)
  Update babel-present-env and use node: 'current' as target (facebook#1051)
  Remove redundant `function` from export statement (facebook#996)
  Add Gatsby to alternatives (facebook#995)
  Allow webpack 2 as peerDependency in react-dev-utils (facebook#963)
  Remove custom babel-loader cache dir config (facebook#983)
  Check for presence of folders before continuing eject. Closes facebook#939. (facebook#951)
  Fixes facebook#952 (facebook#953)
  Always build before deploying to gh-pages (facebook#959)
  Add collectCoverageFrom option to collect coverage on files without any tests. (facebook#961)
  Catch and noop call to open web browser. (facebook#964)
  Gently nudge users towards https by default (facebook#974)
  Enable compression on webpack-dev-server (facebook#966) (facebook#968)
  Add next.js to Alternatives
  Point people to npm Windows instructions
  Encourage people to try recent npm

# Conflicts:
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/package.json
#	packages/react-scripts/utils/createJestConfig.js
@SpaceK33z
Copy link
Contributor

Just a note that this can be closed since the PR has been merged.

@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

Right. Fixed via #968, will be out in 0.8.0.

@gaearon gaearon closed this as completed Nov 20, 2016
@gaearon gaearon added this to the 0.8.0 milestone Nov 20, 2016
jarlef pushed a commit to jarlef/create-react-app that referenced this issue Nov 28, 2016
@frontsideair @jarlef
Enable compression on webpack-dev-server (facebook#966) (facebook#968)
cf53613
@cloudmu
Copy link
Contributor

cloudmu commented Jan 9, 2017

FYI, an unexpected consequence of webpack dev server compression is that Server Sent Events over proxy would be buffered, instead of proxied instantaneously.

The issue goes away in production mode, or if I set the webpack dev server compress flag to be false in dev mode.

I bet there are some tricks that would allow compression on without affecting Server Sent Events, but I haven't figured it out yet.

alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this issue Jan 23, 2017
@frontsideair @alexdriaguine
Enable compression on webpack-dev-server (facebook#966) (facebook#968)
c55aa7c
@chrsan chrsan mentioned this issue Feb 24, 2017
Closed
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this issue May 8, 2017
@frontsideair @randycoulman
Enable compression on webpack-dev-server (facebook#966) (facebook#968)
5c036d1
@bogdan-calapod bogdan-calapod mentioned this issue Feb 20, 2018
Closed
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this issue Mar 7, 2018
@kitze
Merge branch 'master' of https://github.com/facebookincubator/create-…
9e4a35f 
…react-app

# By Ville Immonen (11) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app: (39 commits)
  Remove redundant `function` from export statement (facebook#996)
  Add Gatsby to alternatives (facebook#995)
  Allow webpack 2 as peerDependency in react-dev-utils (facebook#963)
  Remove custom babel-loader cache dir config (facebook#983)
  Check for presence of folders before continuing eject. Closes facebook#939. (facebook#951)
  Fixes facebook#952 (facebook#953)
  Always build before deploying to gh-pages (facebook#959)
  Add collectCoverageFrom option to collect coverage on files without any tests. (facebook#961)
  Catch and noop call to open web browser. (facebook#964)
  Gently nudge users towards https by default (facebook#974)
  Enable compression on webpack-dev-server (facebook#966) (facebook#968)
  Add next.js to Alternatives
  Point people to npm Windows instructions
  Encourage people to try recent npm
  Fix an attribution link in 0.7.0 changelog
  Update CLI version in changelog
  Publish
  Update eslint-config-react-app version in the guide
  Update changelog for 0.7.0
  Revert "Temporarily remove 0.7.0 changelog as it's not out yet"
  ...

Conflicts:
	packages/babel-preset-react-app/package.json
	packages/create-react-app/package.json
	packages/eslint-config-react-app/package.json
	packages/react-dev-utils/package.json
	packages/react-scripts/config/webpack.config.dev.js
	packages/react-scripts/config/webpack.config.prod.js
	packages/react-scripts/package.json
@don-p
Copy link

don-p commented Dec 14, 2018

FYI, an unexpected consequence of webpack dev server compression is that Server Sent Events over proxy would be buffered, instead of proxied instantaneously.

The issue goes away in production mode, or if I set the webpack dev server compress flag to be false in dev mode.

I bet there are some tricks that would allow compression on without affecting Server Sent Events, but I haven't figured it out yet.

This has most certainly caused problems with Server-Sent-Events. I'm using this in my project, and have determined that the gzip compression is causing the event connection to close. I'm struggling to find a way to unset this - however, it's not clear to me why this change was made, since in a development environment it's a low-impact issue to have non-compressed files served. The trade-off of making SSE unusable doesn't seem to have been a good call.

Thanks.

@Timer
Copy link
Contributor

Timer commented Dec 28, 2018

Hi! Please open a new issue for this -- it's hard to track when commenting on old issues.

@lock lock bot locked and limited conversation to collaborators Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
6 participants
@SpaceK33z @Timer @gaearon @frontsideair @don-p @cloudmu