Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document SKIP_PREFLIGHT_CHECK, improve err messaging #11119

Open
eckdanny opened this issue Jun 17, 2021 · 0 comments · May be fixed by #11122
Open

document SKIP_PREFLIGHT_CHECK, improve err messaging #11119

eckdanny opened this issue Jun 17, 2021 · 0 comments · May be fixed by #11122
Labels
issue: proposal needs triage

Comments

@eckdanny
Copy link

Is your proposal related to a problem?

Unclear that PREFLIGHT_CHECK consists only of verifyPackageTree. CRA users in non-traditional environments (e.g.; git submodules, lerna, yarn workspaces) encountering this can get a false positive because normal node module resolution indeed works just fine.

refs:

Describe the solution you'd like

  1. Wordsmith the error messaging in verifyPackageTree.js to indicate this is only a footgun check
  2. Add something to the docs site about this flag. AFAIK, there is no mention of SKIP_PREFLIGHT_CHECK anywhere in the docs site, but adding to /docusaurus/docs/advanced-configuration.md at minimum would be a good idea.

Describe alternatives you've considered

Would be nice if the SKIP_PREFLIGHT_CHECK had a more descriptive name, but not worth changing IMO.
eckdanny added a commit to eckdanny/create-react-app that referenced this issue Jun 18, 2021
@eckdanny
add docs for SKIP_PREFLIGHT_CHECK
52572ae 
Adds entry in docusaurus site. Provides additional context in `verifyPackageTree` error messaging.

Closes facebook#11119.
eckdanny added a commit to eckdanny/create-react-app that referenced this issue Jun 18, 2021
@eckdanny
add docs for SKIP_PREFLIGHT_CHECK
c2fdeb8 
Adds entry in docusaurus site. Provides additional context in `verifyPackageTree` error messaging.

Closes facebook#11119.
@eckdanny eckdanny linked a pull request Jun 18, 2021 that will close this issue
Open
kristielim added a commit to rockset/rockset-js that referenced this issue Dec 13, 2021
@kristielim
[PX-998] Revert removing local serve
aaef2cb 
Summary:
Revert this commit: 4c260c7
I regenerated yarn.lock
Many packages have dropped support node 10 so I have updated the github build to only use node 10 as well (deploy only uses node 12).
In addition, I have included the environment variable `SKIP_PREFLIGHT_CHECK` so that the build succeeds.
If the check is there, then the build does not succeed because of an incompatibility in versions of eslint in create-react-app compared to the rockset-js repo.
facebook/create-react-app#11119

Test Plan: Build is green, was able to run local:serve locally

Reviewers: #product, joe, scott

Reviewed By: #product, scott

Subscribers: scott

Differential Revision: https://rockset.phacility.com/D14943
@kristielim kristielim mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: proposal needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add docs for SKIP_PREFLIGHT_CHECK eckdanny/create-react-app
1 participant
@eckdanny