Fix InterpolateHtmlPlugin only replacing the first occurrence (#731)

Fixes #625 (comment).
facebook · Sep 23, 2016 · e41d671 · e41d671
1 parent 500fb74
commit e41d671
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/react-dev-utils/InterpolateHtmlPlugin.js b/packages/react-dev-utils/InterpolateHtmlPlugin.js
@@ -16,6 +16,7 @@
 // https://github.com/ampedandwired/html-webpack-plugin#events
 
 'use strict';
+const escapeStringRegexp = require('escape-string-regexp');
 
 class InterpolateHtmlPlugin {
   constructor(replacements) {
@@ -29,7 +30,10 @@ class InterpolateHtmlPlugin {
           // Run HTML through a series of user-specified string replacements.
           Object.keys(this.replacements).forEach(key => {
             const value = this.replacements[key];
-            data.html = data.html.replace('%' + key + '%', value);
+            data.html = data.html.replace(
+              new RegExp('%' + escapeStringRegexp(key) + '%', 'g'),
+              value
+            );
           });
           callback(null, data);
         }

diff --git a/packages/react-dev-utils/package.json b/packages/react-dev-utils/package.json
@@ -22,6 +22,7 @@
   ],
   "dependencies": {
     "chalk": "1.1.3",
+    "escape-string-regexp": "1.0.5",
     "opn": "4.0.2"
   },
   "peerDependencies": {