latest

'buck2_server/cmd/ctx': Remove most anyhow usage

Summary: Migrates most uses of `anyhow` in the crate to `buck2_error`. Only a starlark function was skipped and will be dealt with later

Reviewed By: JakobDegen

Differential Revision: D66367353

fbshipit-source-id: 1073ac07c262d633d69e089923baaff35e0be3f6

2024-11-15

argfiles: Clean up dependency on `canonicalize` and `cwd`

Summary: I was hoping to remove the `canonicalize` call here but that turns out to be a bit hard - but let's at least make the reason it has to be there more explicit, and also not reuse the immediate context for the cwd

Reviewed By: stepancheg

Differential Revision: D65845854

fbshipit-source-id: 11cfd4cf8680a99436727cdc3a20191db484a2e4

2024-11-01

Convert log commands to record InvocationRecord

Summary: Log commands don't have any InvocationRecord generated.  I would like to track details about who/how invokes log commands. Let's ensure they are written to buck2_builds table with no event log option (so scrapped from scribe?).

Reviewed By: iguridi

Differential Revision: D64044944

fbshipit-source-id: d4ec4a9fe3cc12224f8344dea218abe96a49223c

2024-10-15

Refactor derive(Freeze)

Summary:
Use the same parser for `#[freeze]` on struct and on field. Errors with better spans.

For future changes. What we need is something like

```
#[freeze(frozen = ...)]
```

to `derive(Freeze)` when some fields are generic but freeze is identity. Currently it is not possible, because even if bounds is specified, generated code still uses `T::Frozen` for frozen type parameter.

Reviewed By: JakobDegen

Differential Revision: D64337850

fbshipit-source-id: 970c3ade11061b9f3bd4f55baabf78cc076a9f6d

2024-10-01

Include ExecutionPlatformResolutionKey in cfg graph cycle detector.

Summary: ^

Reviewed By: JakobDegen

Differential Revision: D63337541

fbshipit-source-id: 42f53c1c9660cc936fff7111b054c26bd6ecb696

2024-09-16

Fix integer overflow in test_host_cpu_load_info

Reviewed By: JakobDegen

Differential Revision: D62703434

fbshipit-source-id: 27e9d747c25cdc928965b2e6c3406c5dc97c6190

2024-09-02

Add class to source map support for instrumentation test apk

Summary: We are using coverage data for code coverage based test selection and we need to coverate data for test itself to make sure that we will select it in only test was changed.

Reviewed By: IanChilds

Differential Revision: D62024851

fbshipit-source-id: 81ecb75f1135b4f96f3d85f6624051c93f496786

2024-08-15

Fixup for linkage on doctests

Summary:
We need to pass deps as immediate dependencies alongside the rlib when constructing linker args, so that we actually get the required `-lfoo` etc args on the link line.

Without this, we get undefined symbols when building doctests with `advanced_unstable_linking`.

Reviewed By: JakobDegen

Differential Revision: D61298029

fbshipit-source-id: 65594651e3f4716771b3e8d91bfd482fbd430222

2024-08-01

rust-project: Don't use incremental actions for clippy

Summary: D59887013 seems to have broken clippy warnings, although it's unclear to me why. Revert that change so we continue to offer clippy warnings in the IDE.

Reviewed By: Imxset21

Differential Revision: D60558322

fbshipit-source-id: 954b4f1093452bbbd474a4031e4b790bcf77355d

2024-07-15

configs: Fallible file existence check

Summary: This operation is not actually infallible

Reviewed By: stepancheg

Differential Revision: D59664959

fbshipit-source-id: 11916f71b50919910bd9ca5491372804d1c41b10