Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-project check TARGET #767

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

rust-project check TARGET #767

wants to merge 8 commits into from

Commits on Sep 4, 2024

  1. TEMPORARY: add rust-analyzer to rust-toolchain so OSS devs can contri… 

    …bute
    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a838ef6 View commit details
    Browse the repository at this point in the history

  2. rust-project: make it possible to debug errors in check.bxl again 

    By fixing & removing the workaround for missing JSON output that
swallowed all the BXL errors too.
    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f8d80ea View commit details
    Browse the repository at this point in the history

  3. rust-project check TARGET instead of SAVED_FILE

    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    839aa95 View commit details
    Browse the repository at this point in the history

  4. Add some OSS-compatible runnables

    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4c8384f View commit details
    Browse the repository at this point in the history

  5. rust-project develop --use-clippy false

    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5b59f18 View commit details
    Browse the repository at this point in the history

  6. rust-project: Always write sysroot_src as std/core are not available … 

    …otherwise
    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0917216 View commit details
    Browse the repository at this point in the history

  7. Fully custom --sysroot --sysroot-src + sanity checks 

    This became necessary when I was debugging a sysroot that by mistake did not have
rust-src due to being a "minimal" rustup toolchain. I figure that might be a common
mistake.
    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0790b05 View commit details
    Browse the repository at this point in the history

  8. use cfg(fbcode_build) to determine which runnables to add

    @cormacrelf
    cormacrelf committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fe75587 View commit details
    Browse the repository at this point in the history