Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cxx requires both clang and lld #131

Closed

Conversation

zhouhaibing089
Copy link
Contributor

@zhouhaibing089 zhouhaibing089 commented Apr 9, 2023

While trying the guide on my archlinux desktop, I saw the following errors if I only have clang installed (via pacman -S clang)

$ buck2 build //...
Action failed: root//:main (cxx_link_executable)
Local command returned non-zero exit code 1
Reproduce locally: `clang++ "-fuse-ld=lld" -o buck-out/v2/gen/root/524f8da68ea2a374/__main__/main @buck-out/v2/gen/root/524f8da68ea2a374/__main__/main.linker.argsfile`
stdout:
stderr:
clang-15: error: invalid linker name in argument '-fuse-ld=lld'
Action failed: root//:print (cxx_link lib_print.so)
Local command returned non-zero exit code 1
Reproduce locally: `clang++ "-fuse-ld=lld" -o buck-out/v2/gen/root/524f8da68ea2a374/__print__/lib_print.so @buck-out/v2/gen/root/524f8da68ea2a374/__print__/lib_print.so.linker.argsfile`
stdout:
stderr:
clang-15: error: invalid linker name in argument '-fuse-ld=lld'
Build ID: c967e7ad-5e3c-49ac-8b92-bb5827cf9100
Jobs completed: 55. Time elapsed: 0.2s. Cache hits: 0%. Commands: 8 (cached: 0, remote: 0, local:
BUILD FAILED
Failed to build 'root//:main (prelude//platforms:default#524f8da68ea2a374)'
Failed to build 'root//:print (prelude//platforms:default#524f8da68ea2a374)'

It turns out that I need lld to be available as well (via pacman -S lld).

While trying the guids on my archlinux desktop, I saw the following errors if I
only have `clang` installed (via `pacman -S clang`)

```
$ buck2 build //...
Action failed: root//:main (cxx_link_executable)
Local command returned non-zero exit code 1
Reproduce locally: `clang++ "-fuse-ld=lld" -o buck-out/v2/gen/root/524f8da68ea2a374/__main__/main @buck-out/v2/gen/root/524f8da68ea2a374/__main__/main.linker.argsfile`
stdout:
stderr:
clang-15: error: invalid linker name in argument '-fuse-ld=lld'
Action failed: root//:print (cxx_link lib_print.so)
Local command returned non-zero exit code 1
Reproduce locally: `clang++ "-fuse-ld=lld" -o buck-out/v2/gen/root/524f8da68ea2a374/__print__/lib_print.so @buck-out/v2/gen/root/524f8da68ea2a374/__print__/lib_print.so.linker.argsfile`
stdout:
stderr:
clang-15: error: invalid linker name in argument '-fuse-ld=lld'
Build ID: c967e7ad-5e3c-49ac-8b92-bb5827cf9100
Jobs completed: 55. Time elapsed: 0.2s. Cache hits: 0%. Commands: 8 (cached: 0, remote: 0, local:
BUILD FAILED
Failed to build 'root//:main (prelude//platforms:default#524f8da68ea2a374)'
Failed to build 'root//:print (prelude//platforms:default#524f8da68ea2a374)'
```

It turns out that I need `lld` to be available as well (via `pacman -S lld`).
@facebook-github-bot
Copy link
Contributor

Hi @zhouhaibing089!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2023
@facebook-github-bot
Copy link
Contributor

@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ndmitchell
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants