Skip to content

Commit

Permalink
starlark_lsp: remove all completion triggers
Browse files Browse the repository at this point in the history
Summary:
D53530861 removed a few completion triggers that were uncontroversial, and this improved the appearance of annoying autocomplete popups.
This diff removes the rest of the trigger characters, because after further testing they aren't very useful:

opening parenthesis:
{F1456353169}

string quote:
{F1456353307}

assignment doesn't seem to work anyway.

Reviewed By: JakobDegen

Differential Revision: D53756130

fbshipit-source-id: 8bc9ef96158f9320d37f8382406de298099e5f0a
  • Loading branch information
zsol authored and facebook-github-bot committed Feb 15, 2024
1 parent dee0282 commit d824120
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions starlark-rust/starlark_lsp/src/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ use lsp_types::request::GotoDefinition;
use lsp_types::request::HoverRequest;
use lsp_types::CompletionItem;
use lsp_types::CompletionItemKind;
use lsp_types::CompletionOptions;
use lsp_types::CompletionParams;
use lsp_types::CompletionResponse;
use lsp_types::DefinitionOptions;
Expand Down Expand Up @@ -406,17 +405,6 @@ impl<T: LspContext> Backend<T> {
ServerCapabilities {
text_document_sync: Some(TextDocumentSyncCapability::Kind(TextDocumentSyncKind::FULL)),
definition_provider,
completion_provider: Some(CompletionOptions {
trigger_characters: Some(vec![
// e.g. function call
"(".to_owned(),
// e.g. variable assignment
"=".to_owned(),
// e.g. string literal (load path, target name)
"\"".to_owned(),
]),
..Default::default()
}),
hover_provider: Some(HoverProviderCapability::Simple(true)),
..ServerCapabilities::default()
}
Expand Down

0 comments on commit d824120

Please sign in to comment.