Fix linking for boost::program_options, fix ubuntu packages

Summary:
program_options is not a header only library, and has linking
failures. Also fix resolution of ubuntu packages, which replace "_" with "-".

Reviewed By: bigfootjon

Differential Revision: D66305639

fbshipit-source-id: 2486cc5cf3885b09ad2228911022023840c0f7b7

third-party/boost/BUCK

@@ -16,7 +16,6 @@ boost_libs(
         "lexical_cast",
         "multi_index",
         "preprocessor",
-        "program_options",
         "range",
         "sort",
         "variant",
@@ -25,6 +24,7 @@ boost_libs(
         "container",
         "context",
         "filesystem",
+        "program_options",
         "random",
         "regex",
         "thread",

third-party/boost/boost.bzl

@@ -7,8 +7,6 @@
 
 load("@//third-party:defs.bzl", "system_library")
 
-HOMEBREW_BREW = "boost"
-
 def boost_libs(libraries, header_only):
     system_library(
         name = "boost",
@@ -33,7 +31,7 @@ def boost_library(library: str, header_only: bool):
         packages = {
             "//os:linux-fedora": ["boost-devel"],
             "//os:linux-ubuntu": [
-                "libboost-dev" if header_only else "libboost-{}-dev".format(library),
+                "libboost-dev" if header_only else "libboost-{}-dev".format(library.replace("_", "-")),
             ],
             "//os:macos-homebrew": ["boost"],
         },