Add kotlin rules support to buck project #1200
Conversation
|
cc @dsyang |
| ModuleBuildContext context) { | ||
| addDepsAndSources( | ||
| target, | ||
| false /* wantsPackagePrefix */, |
There was a problem hiding this comment.
Question: What does this do?
There was a problem hiding this comment.
I just copied it from the groovy rule :)
There was a problem hiding this comment.
More info here:
There was a problem hiding this comment.
this option is there mostly because fb source layout is weird and doesn't match Intellij convention. At the same time, given the similarity between kotlin and java, it might not be a bad idea to have it. Give it a shot, if it works with this set to true maybe just leave it in?
|
Ill fix the tests and re-upload. ant tests passed for me. Need to look at the buck build path |
|
@kageiit updated the pull request - view changes |
facebook-github-bot
added
GH Review: review-needed
Import Started
and removed
GH Review: needs-revision
labels
|
@dsyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@kageiit can you rebase again? Some internal tests are failing and I think it's b/c of a merge conflict |
kageiit
force-pushed
the
kotlin_project_support
branch
from
db4d3dd to
92872a6
Compare
|
@dsyang rebased on latest and force pushed |
|
@kageiit updated the pull request - view changes - changes since last import |
|
@dsyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@dsyang any update on the import? |
|
Figuring it out today.
…On Mar 1, 2017 3:34 PM, "Gautam Korlam" ***@***.***> wrote:
@dsyang <https://github.com/dsyang> any update on the import?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1200 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAgWMWuY1qyR10j98MQAYKQ65xPyIJtrks5rhgBrgaJpZM4MJB8A>
.
|
No description provided.