[omm] Exchanges CRUD functions and tests #1374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dcallies
reviewed
Sep 29, 2023
|
|
||
|
|
||
| @dataclass | ||
| class Hash(db.Model): # type: ignore[name-defined] # Should this be Signal? |
There was a problem hiding this comment.
This is duplicate with ContentSignal
| @@ -0,0 +1,39 @@ | |||
| """empty message | |||
There was a problem hiding this comment.
Doing migrations at this stage seems like an undue burden. Easy enough to do flask reset_all_tables
| class ContentSignal(db.Model): # type: ignore[name-defined] | ||
| id: Mapped[int] = mapped_column(primary_key=True) | ||
| content_id: Mapped[int] = mapped_column(ForeignKey("bank_content.id")) | ||
| signal_type: Mapped[str] | ||
| signal_val: Mapped[str] = mapped_column(Text) | ||
| id: Mapped[int] = db.Column(dbtypes.Integer, primary_key=True, autoincrement=True) |
There was a problem hiding this comment.
Why not mapped syntax? This seems like the preferred one
| @@ -64,8 +69,36 @@ def as_storage_iface_cls(self) -> BankContentConfig: | |||
| ) | |||
|
|
|||
|
|
|||
| @dataclass | |||
There was a problem hiding this comment.
This interacts strangely with db.Model and the columns - I found a few edge cases during working that I couldn't find a workaround to. I'm not sure its worth keeping :/
|
Hey @dougneal , I'm going to close this PR for inactivity, feel free to re-open if you still want to try and get it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan