Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omm][temporarily breaking] Bank relationships and some storage iface #1372

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

Dcallies
Copy link
Contributor

Summary

This PR:

  1. Does some more work on the bank data model, which should flex it out to allow bank -> content -> hashes
  2. Rewrites some of the sqlalchemy in whatever the heck the mainline docs use: https://flask-sqlalchemy.palletsprojects.com/en/3.1.x/quickstart/ and https://docs.sqlalchemy.org/en/20/orm/basic_relationships.html#one-to-many
  3. Breaks the existing curation API while I continue tooling on it

As part of this, I couldn't figure out a way to make both sqlalchemy and dataclasses happy at the same time, so we're doing something immensely stupid and just translating between them.

Test Plan

mypy

@Dcallies Dcallies merged commit c4d15e9 into main Sep 29, 2023
5 checks passed
@Dcallies Dcallies deleted the bank_relationships_and_storage branch September 29, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants