Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deprecated mirrorlist..centos.org api #282

Closed
wants to merge 2 commits into from

Conversation

liteburn
Copy link

@liteburn liteburn commented Jul 6, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Replace deprecated mirrorlist..centos.org with vault.centos.org after support of centOS8 has ended.

Which issue(s) this PR fixes:
Fixes #281

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Additional documentation e.g., Design Proposals, usage docs, etc.:


@facebook-github-bot
Copy link
Contributor

@gbatye has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@liteburn has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@rslowe has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@rslowe
Copy link
Contributor

rslowe commented Jul 19, 2024

There were some issues while I was importing this PR. It seems that the CentOS repo has changed quite a bit from the last time the team has touched this cookbook. (vault.centos.org does not resolve to a mirrorlist, it resolves to an actual repo.)

I've made changes to this PR internally and will upload those changes to the repo shortly.

If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2024
…rg URL (#282)

Summary:
This originally was PR #282, but the original pull request had issues that failed in internal testing. Credit to liteburn for the original PR.

Resolves #281.

Differential Revision: D59592724

fbshipit-source-id: d7c7ac989fed429e40725872edd78e3546ed1528
@rslowe rslowe closed this Jul 19, 2024
@rslowe
Copy link
Contributor

rslowe commented Jul 19, 2024

Merged as f979f7a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mirrorlist..centos.org api is now deprecated
3 participants