Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect arg name for ChoiceParameter #92

Closed
wants to merge 1 commit into from
Closed

Conversation

kkashin
Copy link
Contributor

@kkashin kkashin commented May 15, 2019

value -> values

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 15, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkashin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files         218      218           
  Lines       12166    12166           
=======================================
  Hits        11385    11385           
  Misses        781      781

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2fff8...debdaed. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@kkashin merged this pull request in d4bfc96.

@kkashin kkashin deleted the kkashin-patch-2 branch August 7, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants