Validation and narrower try/except in BenchmarkMetric #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66301697 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3100 +/- ##
==========================================
+ Coverage 95.41% 95.43% +0.01%
==========================================
Files 495 495
Lines 49941 49956 +15
==========================================
+ Hits 47653 47674 +21
+ Misses 2288 2282 -6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Summary: **Context**: `BenchmarkMetric.fetch_data` originally had a broad try/except block just because this the usual way to define metrics. The try/except is actually not needed at all; with benchmarking, there are no potentially-flaky RPCs and we completely understand what should happen when fetching data; thus, `BenchmarkMapMetric` has no try/except. The following cases are possible when fetching data: * If the trial has not been run, it will have no metadata, and there should be a `MetricFetchE` (error). * If a trial has been run, it should have properly formatted metadata, and `fetch_data` should succeed. * If there is a problem with the metadata, this really shouldn't happen, and `fetch_data` should form with an informative error. **This PR**: * Unifies the logic between `BenchmarkMetric` and `BenchmarkMapMetric` so that both return a `MetricFetchE` when there is no metadata and do not have a try/except * Pulls out a mixin for code-sharing Reviewed By: Balandat Differential Revision: D66301697
esantorella
force-pushed
the
export-D66301697
branch
from
c3c337a
to
6d512ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66301697 |
|
This pull request has been merged in 095d7ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
BenchmarkMetric.fetch_dataoriginally had a broad try/except block just because this the usual way to define metrics. The try/except is actually not needed at all; with benchmarking, there are no potentially-flaky RPCs and we completely understand what should happen when fetching data.BenchmarkMapMetrichas no try/except. The following cases are possible when fetching data:MetricFetchE(error).fetch_datashould succeed.fetch_datashould form with an informative error.This PR:
BenchmarkMetricandBenchmarkMapMetricso that both return aMetricFetchEwhen there is no metadata and do not have a try/exceptDifferential Revision: D66301697