Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyre fixme for downstream type errors from D65753120 #3055

Closed
wants to merge 1 commit into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 12, 2024

Summary:
X-link: https://github.com/ctrl-labs/src2/pull/38515

X-link: https://github.com/ctrl-labs/src2/pull/38514

Reviewed By: jermenkoo

Differential Revision: D65826205

Summary:
X-link: ctrl-labs/src2#38515

X-link: ctrl-labs/src2#38514

Reviewed By: jermenkoo

Differential Revision: D65826205
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65826205

ezyang added a commit to ezyang/captum that referenced this pull request Nov 12, 2024
Summary:
X-link: facebook/Ax#3055

X-link: ctrl-labs/src2#38515

X-link: ctrl-labs/src2#38514

Reviewed By: jermenkoo

Differential Revision: D65826205
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (03f1b95) to head (589fa25).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3055   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files         485      485           
  Lines       49166    49166           
=======================================
  Hits        47029    47029           
  Misses       2137     2137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

facebook-github-bot pushed a commit to pytorch/FBGEMM that referenced this pull request Nov 12, 2024
Summary:
X-link: pytorch/captum#1439

X-link: facebook/Ax#3055

X-link: ctrl-labs/src2#38515

X-link: ctrl-labs/src2#38514

bypass-github-export-checks "The check is bugged, I exported all the required exports"

Reviewed By: jermenkoo

Differential Revision: D65826205

fbshipit-source-id: b08f00caaac8f3cc235bc280c4fe3f99089a0753
facebook-github-bot pushed a commit to pytorch/captum that referenced this pull request Nov 12, 2024
Summary:
Pull Request resolved: #1439

X-link: facebook/Ax#3055

X-link: ctrl-labs/src2#38515

X-link: ctrl-labs/src2#38514

bypass-github-export-checks "The check is bugged, I exported all the required exports"

Reviewed By: jermenkoo

Differential Revision: D65826205

fbshipit-source-id: b08f00caaac8f3cc235bc280c4fe3f99089a0753
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3889615.

facebook-github-bot pushed a commit to facebookresearch/ReAgent that referenced this pull request Nov 12, 2024
Summary:
X-link: pytorch/captum#1439

X-link: facebook/Ax#3055

X-link: ctrl-labs/src2#38515

X-link: ctrl-labs/src2#38514

bypass-github-export-checks "The check is bugged, I exported all the required exports"

Reviewed By: jermenkoo

Differential Revision: D65826205

fbshipit-source-id: b08f00caaac8f3cc235bc280c4fe3f99089a0753
facebook-github-bot pushed a commit to pytorch/torcheval that referenced this pull request Nov 12, 2024
Summary:
X-link: pytorch/captum#1439

X-link: facebook/Ax#3055

X-link: ctrl-labs/src2#38515

X-link: ctrl-labs/src2#38514

bypass-github-export-checks "The check is bugged, I exported all the required exports"

Reviewed By: jermenkoo

Differential Revision: D65826205

fbshipit-source-id: b08f00caaac8f3cc235bc280c4fe3f99089a0753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants