Refactor computation of optimization trace #2747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62250058 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2747 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 489 489
Lines 47876 47913 +37
=======================================
+ Hits 45709 45747 +38
+ Misses 2167 2166 -1 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D62250058 |
esantorella
force-pushed
the
export-D62250058
branch
from
f93cdf2
to
1ca80a2
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebook#2747 * Add `BenchmarkProblem.get_oracle_experiment_from_params`, a method to compute an experiment where parameters are evaluated at oracle values. This will be useful once we enable inference regret. * Add a helper `get_oracle_experiment_from_experiment` to replicate the old behavior of `get_oracle_experiment`. * Remove `get_opt_trace` from `BenchmarkProblem` and absorbe that logic int `benchmark_replication`; once we have inference regret enabled, how we compute the trace should depend on the _method_, not the problem. The problem should only be responsible for computing oracle values given a parameterization. * Arc lint Differential Revision: D62250058
|
This pull request was exported from Phabricator. Differential Revision: D62250058 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: facebook#2747 * Add `BenchmarkProblem.get_oracle_experiment_from_params`, a method to compute an experiment where parameters are evaluated at oracle values. This will be useful once we enable inference regret. * Add a helper `get_oracle_experiment_from_experiment` to replicate the old behavior of `get_oracle_experiment`. * Remove `get_opt_trace` from `BenchmarkProblem` and absorbe that logic int `benchmark_replication`; once we have inference regret enabled, how we compute the trace should depend on the _method_, not the problem. The problem should only be responsible for computing oracle values given a parameterization. * Arc lint Differential Revision: D62250058
esantorella
force-pushed
the
export-D62250058
branch
from
1ca80a2
to
9fe17bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62250058 |
esantorella
force-pushed
the
export-D62250058
branch
from
9fe17bd
to
9e32e77
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Sep 12, 2024
Summary: Pull Request resolved: facebook#2747 * Add `BenchmarkProblem.get_oracle_experiment_from_params`, a method to compute an experiment where parameters are evaluated at oracle values. This will be useful once we enable inference regret. * Add a helper `get_oracle_experiment_from_experiment` to replicate the old behavior of `get_oracle_experiment`. * Remove `get_opt_trace` from `BenchmarkProblem` and absorbe that logic int `benchmark_replication`; once we have inference regret enabled, how we compute the trace should depend on the _method_, not the problem. The problem should only be responsible for computing oracle values given a parameterization. * Arc lint Differential Revision: D62250058
|
This pull request was exported from Phabricator. Differential Revision: D62250058 |
esantorella
force-pushed
the
export-D62250058
branch
from
9e32e77
to
10b6027
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: facebook#2747 * Add `BenchmarkProblem.get_oracle_experiment_from_params`, a method to compute an experiment where parameters are evaluated at oracle values. This will be useful once we enable inference regret. * Add a helper `get_oracle_experiment_from_experiment` to replicate the old behavior of `get_oracle_experiment`. * Remove `get_opt_trace` from `BenchmarkProblem` and absorbe that logic int `benchmark_replication`; once we have inference regret enabled, how we compute the trace should depend on the _method_, not the problem. The problem should only be responsible for computing oracle values given a parameterization. * Arc lint Reviewed By: Balandat Differential Revision: D62250058
Summary: Pull Request resolved: facebook#2747 * Add `BenchmarkProblem.get_oracle_experiment_from_params`, a method to compute an experiment where parameters are evaluated at oracle values. This will be useful once we enable inference regret. * Add a helper `get_oracle_experiment_from_experiment` to replicate the old behavior of `get_oracle_experiment`. * Remove `get_opt_trace` from `BenchmarkProblem` and absorbe that logic int `benchmark_replication`; once we have inference regret enabled, how we compute the trace should depend on the _method_, not the problem. The problem should only be responsible for computing oracle values given a parameterization. * Arc lint Reviewed By: Balandat Differential Revision: D62250058
|
This pull request was exported from Phabricator. Differential Revision: D62250058 |
esantorella
force-pushed
the
export-D62250058
branch
from
10b6027
to
1974be6
Compare
|
This pull request has been merged in acc9df2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
BenchmarkProblem.get_oracle_experiment_from_params, a method to compute an experiment where parameters are evaluated at oracle values. This will be useful once we enable inference regret.get_oracle_experiment_from_experimentto replicate the old behavior ofget_oracle_experiment.get_opt_tracefromBenchmarkProblemand absorbe that logic intbenchmark_replication; once we have inference regret enabled, how we compute the trace should depend on the method, not the problem. The problem should only be responsible for computing oracle values given a parameterization.Differential Revision: D62250058