Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more candidate trials than max_trials in Scheduler #2689

Closed
wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

Summary: see title. This is useful for queueing trials manually

Reviewed By: bernardbeckerman

Differential Revision: D61508135

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 21, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61508135

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (9804f70) to head (26dd3af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2689   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         492      492           
  Lines       47816    47834   +18     
=======================================
+ Hits        45567    45585   +18     
  Misses       2249     2249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:
Pull Request resolved: facebook#2689

see title. This is useful for queueing trials manually

Reviewed By: bernardbeckerman

Differential Revision: D61508135
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61508135

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a163817.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants