Modify get_data to error out on nan/inf #2633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60681606 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2633 +/- ##
=======================================
Coverage 95.30% 95.31%
=======================================
Files 492 492
Lines 47583 47614 +31
=======================================
+ Hits 45351 45382 +31
Misses 2232 2232 ☔ View full report in Codecov by Sentry. |
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Aug 5, 2024
Summary: Pull Request resolved: facebook#2633 This method is leveraged by `StandardizeY`, `Winsorize`, `PowerTransformY`, and `PercentileY`. This change will improve the robustness of our transform layer to non-finite values and error out before we pass those down to BoTorch. Reviewed By: Balandat Differential Revision: D60681606
|
This pull request was exported from Phabricator. Differential Revision: D60681606 |
Summary: Pull Request resolved: facebook#2633 This method is leveraged by `StandardizeY`, `Winsorize`, `PowerTransformY`, and `PercentileY`. This change will improve the robustness of our transform layer to non-finite values and error out before we pass those down to BoTorch. Reviewed By: Balandat Differential Revision: D60681606
|
This pull request was exported from Phabricator. Differential Revision: D60681606 |
|
This pull request has been merged in db934f7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This method is leveraged by
StandardizeY,Winsorize,PowerTransformY, andPercentileY.This change will improve the robustness of our transform layer to non-finite values and error out before we pass those down to BoTorch.
Differential Revision: D60681606