Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Standardize by default for SingleTaskGP #2630

Closed
wants to merge 1 commit into from

Conversation

dme65
Copy link
Contributor

@dme65 dme65 commented Aug 2, 2024

Summary: D60080819 recently updated the default SingleTaskGP BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the SingleTaskGP to use Standardize by default if no outcome transforms are specified (this allows users to explicitly pass in None if they don't want to use any transforms).

Differential Revision: D60492937

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (837e422) to head (3c6acee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2630   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files         493      493           
  Lines       47640    47642    +2     
=======================================
+ Hits        45388    45390    +2     
  Misses       2252     2252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 2, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 2, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 2, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 7, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

dme65 pushed a commit to dme65/Ax that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 7, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

dme65 pushed a commit to dme65/Ax that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 7, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 7, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

dme65 pushed a commit to dme65/Ax that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 7, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

dme65 pushed a commit to dme65/Ax that referenced this pull request Aug 7, 2024
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 8, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/Ax that referenced this pull request Aug 8, 2024
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` and `Normalize` by default if no input/outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

@dme65 dme65 changed the title Use Standardize/Normalize by default for SingleTaskGP Use Standardizeby default for SingleTaskGP Aug 9, 2024
@dme65 dme65 changed the title Use Standardizeby default for SingleTaskGP Use Standardize by default for SingleTaskGP Aug 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

dme65 pushed a commit to dme65/Ax that referenced this pull request Aug 9, 2024
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` by default if no outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 9, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` by default if no outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 9, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` by default if no outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

dme65 pushed a commit to dme65/Ax that referenced this pull request Aug 9, 2024
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` by default if no outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Differential Revision: D60492937
Summary:
Pull Request resolved: facebook#2630

X-link: pytorch/botorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` by default if no outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Reviewed By: esantorella

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60492937

dme65 pushed a commit to dme65/botorch that referenced this pull request Aug 9, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: pytorch#2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` by default if no outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Reviewed By: esantorella

Differential Revision: D60492937
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 52351e8.

facebook-github-bot pushed a commit to pytorch/botorch that referenced this pull request Aug 9, 2024
Summary:
X-link: facebook/Ax#2630

Pull Request resolved: #2458

D60080819 recently updated the default `SingleTaskGP` BoTorch priors. One significant change was to remove the use of an outputscale, which may not work well if the outputs aren't standardized. This diff changes the `SingleTaskGP` to use `Standardize` by default if no outcome transforms are specified (this allows users to explicitly pass in `None` if they don't want to use any transforms).

Reviewed By: esantorella

Differential Revision: D60492937

fbshipit-source-id: 833ff6a2e617e93f1495d978552e29a7ee943e74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants