Make all benchmark problems take an observe_noise_stds argument
#2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Context: One might expect `observe_noise_stds` to apply to either single-objective or multi-objective problems and `observe_noise_sd` applies only to single-objective problems. In reality, problems that derive from BoTorch synthetic test functions take an argument `observe_noise_sd` while those that derive from surrogates have `observe_noise_stds`. I find this needlessly confusing, especially given that we don't have any problems where some outputs have observed noise and others don't, and we might want to use that for either type of problem in the future. This PR: * Gives all problems the argument `observe_noise_stds` only * Updates call sites, mainly for `SingleObjectiveBenchmarkProblem.` Note: Similar to D60194654, breaks backward compatibility Note: Docstrings are updated in the next diff. Differential Revision: D60241406
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60241406 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 495 495
Lines 47748 47745 -3
=======================================
- Hits 45458 45456 -2
+ Misses 2290 2289 -1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 1ab07a7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
One might expect
observe_noise_stdsto apply to either single-objective or multi-objective problems andobserve_noise_sdapplies only to single-objective problems. In reality, problems that derive from BoTorch synthetic test functions take an argumentobserve_noise_sdwhile those that derive from surrogates haveobserve_noise_stds. I find this needlessly confusing, especially given that we don't have any problems where some outputs have observed noise and others don't, and we might want to use that for either type of problem in the future.This PR:
observe_noise_stdsonlySingleObjectiveBenchmarkProblem.Note: Similar to D60194654, breaks backward compatibility
Note: Docstrings are updated in the next diff.
Differential Revision: D60241406