Add an optimal_value to mixed-integer problems
#2596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60144693 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2596 +/- ##
==========================================
- Coverage 95.21% 95.21% -0.01%
==========================================
Files 489 489
Lines 47673 47679 +6
==========================================
+ Hits 45393 45397 +4
- Misses 2280 2282 +2 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jul 24, 2024
Summary: Pull Request resolved: facebook#2596 The next PR will require all problems to have an `optimal_value`. See that PR for more context. This PR adds an optimal value to the mixed-integer problems, which are the only problems that currently lack one. This will be better than the true optimal value because the mixed problems have a restricted search space. Differential Revision: D60144693
esantorella
force-pushed
the
export-D60144693
branch
from
279478a
to
436ca29
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60144693 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60144693 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jul 24, 2024
Summary: Pull Request resolved: facebook#2596 The next PR will require all problems to have an `optimal_value`. See that PR for more context. This PR adds an optimal value to the mixed-integer problems, which are the only problems that currently lack one. This will be better than the true optimal value because the mixed problems have a restricted search space. Reviewed By: saitcakmak Differential Revision: D60144693
esantorella
force-pushed
the
export-D60144693
branch
from
436ca29
to
4e917c4
Compare
Summary: Pull Request resolved: facebook#2596 The next PR will require all problems to have an `optimal_value`. See that PR for more context. This PR adds an optimal value to the mixed-integer problems, which are the only problems that currently lack one. This will be better than the true optimal value because the mixed problems have a restricted search space. Reviewed By: saitcakmak Differential Revision: D60144693
|
This pull request was exported from Phabricator. Differential Revision: D60144693 |
esantorella
force-pushed
the
export-D60144693
branch
from
4e917c4
to
ff556e9
Compare
|
This pull request has been merged in 61a9f88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The next PR will require all problems to have an
optimal_value. See that PR for more context. This PR adds an optimal value to the mixed-integer problems, which are the only problems that currently lack one. This will be better than the true optimal value because the mixed problems have a restricted search space.Differential Revision: D60144693