Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parallel coordinates plot #2590

Closed
wants to merge 1 commit into from

Conversation

mpolson64
Copy link
Contributor

Summary:
An improved version of the parallel coordinates analysis I implemented earlier this year, now refactored with AnalysisCards.

Main improvements include:

  • Ability to infer what metric to use based on the OptimizationConfig if one is not provided
  • Compatibility with ChoiceParameters and FixedParameters
  • Truncation of long parameter and metric names where appropriate

NOTE: This analysis introduces a number of helper functions in parallel_coordinates.py -- as we add more analyses these should be refactored out into analysis/plotly/utils.py or analysis/utils.py as appropriate.

Differential Revision: D59927703

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59927703

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.22%. Comparing base (8587b30) to head (920991d).
Report is 1 commits behind head on main.

Files Patch % Lines
...lotly/parallel_coordinates/parallel_coordinates.py 94.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
+ Coverage   95.20%   95.22%   +0.01%     
==========================================
  Files         492      494       +2     
  Lines       47642    47737      +95     
==========================================
+ Hits        45358    45456      +98     
+ Misses       2284     2281       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59927703

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Jul 19, 2024
Summary:
Pull Request resolved: facebook#2590

An improved version of the parallel coordinates analysis I implemented earlier this year, now refactored with AnalysisCards.

Main improvements include:
* Ability to infer what metric to use based on the OptimizationConfig if one is not provided
* Compatibility with ChoiceParameters and FixedParameters
* Truncation of long parameter and metric names where appropriate

NOTE: This analysis introduces a number of helper functions in parallel_coordinates.py -- as we add more analyses these should be refactored out into analysis/plotly/utils.py or analysis/utils.py as appropriate.

Differential Revision: D59927703
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59927703

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Jul 19, 2024
Summary:
Pull Request resolved: facebook#2590

An improved version of the parallel coordinates analysis I implemented earlier this year, now refactored with AnalysisCards.

Main improvements include:
* Ability to infer what metric to use based on the OptimizationConfig if one is not provided
* Compatibility with ChoiceParameters and FixedParameters
* Truncation of long parameter and metric names where appropriate

NOTE: This analysis introduces a number of helper functions in parallel_coordinates.py -- as we add more analyses these should be refactored out into analysis/plotly/utils.py or analysis/utils.py as appropriate.

Differential Revision: D59927703
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59927703

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Jul 24, 2024
Summary:
Pull Request resolved: facebook#2590

An improved version of the parallel coordinates analysis I implemented earlier this year, now refactored with AnalysisCards.

Main improvements include:
* Ability to infer what metric to use based on the OptimizationConfig if one is not provided
* Compatibility with ChoiceParameters and FixedParameters
* Truncation of long parameter and metric names where appropriate

NOTE: This analysis introduces a number of helper functions in parallel_coordinates.py -- as we add more analyses these should be refactored out into analysis/plotly/utils.py or analysis/utils.py as appropriate.

Differential Revision: D59927703
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59927703

mpolson64 added a commit to mpolson64/Ax that referenced this pull request Jul 26, 2024
Summary:
Pull Request resolved: facebook#2590

An improved version of the parallel coordinates analysis I implemented earlier this year, now refactored with AnalysisCards.

Main improvements include:
* Ability to infer what metric to use based on the OptimizationConfig if one is not provided
* Compatibility with ChoiceParameters and FixedParameters
* Truncation of long parameter and metric names where appropriate

NOTE: This analysis introduces a number of helper functions in parallel_coordinates.py -- as we add more analyses these should be refactored out into analysis/plotly/utils.py or analysis/utils.py as appropriate.

Differential Revision: D59927703
Summary:
Pull Request resolved: facebook#2590

An improved version of the parallel coordinates analysis I implemented earlier this year, now refactored with AnalysisCards.

Main improvements include:
* Ability to infer what metric to use based on the OptimizationConfig if one is not provided
* Compatibility with ChoiceParameters and FixedParameters
* Truncation of long parameter and metric names where appropriate

NOTE: This analysis introduces a number of helper functions in parallel_coordinates.py -- as we add more analyses these should be refactored out into analysis/plotly/utils.py or analysis/utils.py as appropriate.

Reviewed By: Cesar-Cardoso

Differential Revision: D59927703
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59927703

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3e6a0de.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants