Use @fast_botorch_optimize to fix test timeouts #2556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59245218 |
|
This pull request was exported from Phabricator. Differential Revision: D59245218 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jul 1, 2024
Summary: Pull Request resolved: facebook#2556 The tests in this file were timing out when they were fitting SAASBO models. We're decorating the function that fits models with `fast_botorch_optimize`. Reviewed By: saitcakmak Differential Revision: D59245218
danielcohenlive
force-pushed
the
export-D59245218
branch
from
94aa6d9
to
58acedf
Compare
Summary: Pull Request resolved: facebook#2556 The tests in this file were timing out when they were fitting SAASBO models. We're decorating the function that fits models with `fast_botorch_optimize`. Reviewed By: saitcakmak Differential Revision: D59245218
|
This pull request was exported from Phabricator. Differential Revision: D59245218 |
danielcohenlive
force-pushed
the
export-D59245218
branch
from
58acedf
to
aace36f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 485 485
Lines 47348 47352 +4
=======================================
+ Hits 45090 45094 +4
Misses 2258 2258 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in a2e8d47. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The tests in this file were timing out when they were fitting SAASBO models. We're decorating the function that fits models with
fast_botorch_optimize.Reviewed By: saitcakmak
Differential Revision: D59245218