Enable evaluating Branin test experiments with None status quo #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57999540 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2489 +/- ##
=======================================
Coverage 95.27% 95.28%
=======================================
Files 485 485
Lines 47410 47415 +5
=======================================
+ Hits 45172 45178 +6
+ Misses 2238 2237 -1 ☔ View full report in Codecov by Sentry. |
…ook#2489) Summary: The Branin test experiment is really helpful for writing unit tests. None status quo is an important case to consider for some areas. This adds a None status quo handling for the branin test experiment so it can be used for those areas. Reviewed By: mgarrard Differential Revision: D57999540
|
This pull request was exported from Phabricator. Differential Revision: D57999540 |
|
This pull request has been merged in c410658. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The Branin test experiment is really helpful for writing unit tests.
None status quo is an important case to consider for some areas. This adds a
None status quo handling for the branin test experiment so it can be used for
those areas.
Differential Revision: D57999540