Clean up unneccesary todos in _get_model_state_from_last_generator_run #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57444926 |
…r node (facebook#2469) Summary: This diff adds the functionality to generate multiple generator runs per node in a trial that uses multiple nodes. In follow up diffs we will: 1. Support fixed features -- there is ongoing discussion about fixed features on lena-kashtelyan's recent diff, and we may be able to leverage the solution there/help build it out 2. merge this gen method with our standard gen method Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D57398578
facebook#2476) Summary: Since we decided to keep a 1 fitted model : 1 node relationship the note about this being uncompatable with GenNodes is irrelevant now, easy compatability :) Also removed the todo about moving to gennodes - i think it's okay where it is, but if we want to move _fit_current_model and _get_model_state_from_last_generator_run to GenerationNode, that doesn't seem unreasonable and we can keep the todo Reviewed By: lena-kashtelyan Differential Revision: D57444926
mgarrard
force-pushed
the
export-D57444926
branch
from
2de4ae2
to
c97487b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57444926 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
==========================================
- Coverage 95.26% 95.25% -0.01%
==========================================
Files 485 485
Lines 47384 47424 +40
==========================================
+ Hits 45138 45176 +38
- Misses 2246 2248 +2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 449141e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since we decided to keep a 1 fitted model : 1 node relationship the note about this being uncompatable with GenNodes is irrelevant now, easy compatability :)
Also removed the todo about moving to gennodes - i think it's okay where it is, but if we want to move _fit_current_model and _get_model_state_from_last_generator_run to GenerationNode, that doesn't seem unreasonable and we can keep the todo
Reviewed By: lena-kashtelyan
Differential Revision: D57444926