Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing in SyntheticFunctions #2470

Closed
wants to merge 1 commit into from
Closed

Improve typing in SyntheticFunctions #2470

wants to merge 1 commit into from

Commits on May 17, 2024

  1. Improve typing in SyntheticFunctions (facebook#2470) 

    Summary:

A simple Pyre failure was blocking D57473132. I ended up spending way too much time trying out various options for improving typing in this file and settled on this option in the end. Updating the decorator to change the type from `Optional[T] -> T` is something I considered, but it requires the property to be typed as `Optional[T]`, which made me decide to remove the decorator altogether.

Differential Revision: D57508193
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed May 17, 2024
    Configuration menu
    Copy the full SHA
    11e4743 View commit details
    Browse the repository at this point in the history